SteemJ Dev Diary #2 (02.01.2018) - Increased code quality

View this thread on: d.buzz | hive.blog | peakd.com | ecency.com
·@dez1337·
0.000 HBD
SteemJ Dev Diary #2 (02.01.2018) - Increased code quality
*SteemJ Dev Diary #2 (02.01.2018) - Increased code quality.*

<center>
![SteemJV2Logo](https://imgur.com/UQNqn3p.png)
</center>

<center>
Latest SteemJ 0.4.x releases: [0.4.3](https://steemit.com/utopian-io/@dez1337/steemj-v0-4-3-is-available-now-use-the-steem-api-in-your-java-project) [v0.4.2](https://steemit.com/utopian-io/@dez1337/steemj-v0-4-2-is-available-now-use-the-steem-api-in-your-java-project) [v0.4.2pr1](https://steemit.com/steemdev/@dez1337/steemj-v0-4-1-has-been-released-use-the-steem-api-in-your-java-project) [v0.4.1](https://steemit.com/steemdev/@dez1337/steemj-v0-4-1-has-been-released-use-the-steem-api-in-your-java-project) [v0.4.0](https://steemit.com/steemdev/@dez1337/steemj-v0-4-0-has-been-released-integrate-steem-into-your-java-project) 
</center>

# SteemJ Dev Diary #2 (02.01.2018) - Increased code quality
<br>Hello Steemians and welcome back to day #2 of the SteemJ HF 0.20 Dev Diary! 

This series has been introduced to collect feedback from you and to motivate myself to finalize the next SteemJ version as soon as possible. If this is the first part of this series you read, you may want to checkout [Day #1](https://steemit.com/utopian-io/@dez1337/steemj-dev-diary-1-01-01-2018-cryptocore-and-code-cleanups) which explains the motivation behind this diary in detail and also provides a first overview of the API changes that come with HF 0.20.

# Changes during day #2
Sadly, the Steem Node(s) behind the Steem Dev API Endoint [https://api.steemitdev.com](https://api.steemitdev.com) have been changed and the new API calls (using the '_args' and '_return' objects) are not working today. This made it quite hard to test my changes on the API calls.

Anyway, I tried to use the time as good as possible and started to cleanup the "AccountHistoryApi" today. In total I was able to more or less finalize the JavaDoc of all '_args' and '_return' objects related to the "AccountHistoryApi", made sure that default values are applied and that required fields have to be provided. Beside that I've added additional Unit tests to verify that those validations are working properly.

The following commits are related to those changes:
* [b2141bf](https://github.com/marvin-we/steem-java-api-wrapper/commit/b2141bf27a3b6d5f08dea481f9f0e0a74f320db0) Verify that required fields are set (#177)
* [a938d93](https://github.com/marvin-we/steem-java-api-wrapper/commit/a938d93b970b7e0fb0be5a2593e7f5dca1017212) Add additional JavaDoc (#177)
* [86fad4f](https://github.com/marvin-we/steem-java-api-wrapper/commit/86fad4f6c2e42fd134c5091794fdd1f8148f1361) Fix #193

In addition I had a look at [Issue #183 - Use of double for Asset values can cause incorrect trades to be placed.](https://github.com/marvin-we/steem-java-api-wrapper/issues/183) reported by @muksihs . As you may know, it is a pretty bad practice to use 'Double' or 'Float' when working with currencies and sadly, I totally forgot about this when I was implementing the Asset class. In commit [cd851c](https://github.com/marvin-we/steem-java-api-wrapper/commit/cd851c7e81d6817855534173119dcee833f2abe5) the implementation has been changed from 'Double' to 'BigDecimal' and I am currently waiting for @muksihs feedback about this change.

The last change I want to point out for today is commit [7e43f6b](https://github.com/marvin-we/steem-java-api-wrapper/commit/7e43f6bb06e7e55e6d286ca014de536b351100c3), which includes additional test cases for some 'SteemJUtils' methods.

A list of all commits made after the last release can be found here: [https://github.com/marvin-we/steem-java-api-wrapper/compare/v0.4.3...master](https://github.com/marvin-we/steem-java-api-wrapper/compare/v0.4.3...master)

*(A prove that the commits have been made by me can [be found here](https://steemit.com/utopian-io/@dez1337/steemj-image-upload-1-0-0-has-been-released-upload-images-to-steemitimages-com-out-of-your-java-application#@dez1337/re-codingdefined-re-dez1337-steemj-image-upload-1-0-0-has-been-released-upload-images-to-steemitimages-com-out-of-your-java-application-20171217t115152531z))*

# General information
## What is SteemJ?
SteemJ is a project that allows you to communicate with a Steem node using Java. So far, the project supports most of the API calls and is also able to broadcast most of the common operation types. Further information can be found on [GitHub](https://github.com/marvin-we/steem-java-api-wrapper).

> https://github.com/marvin-we/steem-java-api-wrapper

## Quick Start Guide

### Add SteemJ to your project
SteemJ binaries are pushed into the maven central repository and can be integrated with a bunch of build management tools like Maven. The [Wiki](https://github.com/marvin-we/steem-java-api-wrapper/wiki/How-to-add-SteemJ-to-your-project) provides a lot of examples for the most common build tools. If you do not use a build management tool you can download the binaries as described [here](https://github.com/marvin-we/steem-java-api-wrapper/wiki/How-to-add-SteemJ-to-your-project#download).

To add this release to your project paste the following snippet into your 'pom.xml'

```XML
<dependency>
    <groupId>eu.bittrade.libs</groupId>
    <artifactId>steemj-core</artifactId>
    <version>0.4.3</version>
</dependency>
```

### Start posting

```Java
SteemJConfig myConfig = SteemJConfig.getInstance();

myConfig.setDefaultAccount(new AccountName("YOUR-ACCOUNT"));

List<ImmutablePair<PrivateKeyType, String>> privateKeys = new ArrayList<>();
privateKeys.add(new ImmutablePair<>(PrivateKeyType.POSTING, "YOUR-PRIVATE-POSTING-KEY"));

myConfig.getPrivateKeyStorage().addAccount(myConfig.getDefaultAccount(), privateKeys);

steemJ.createComment(new AccountName("steemj"), new Permlink("testofsteemj040"), "Example comment without no link but with a @user .", new String[] { "test" });

```

### Further information
The [sample module](https://github.com/marvin-we/steem-java-api-wrapper/tree/master/sample) of the SteemJ project provides showcases for the most common acitivies and operations users want to perform. 

Beside that you can find a lot of snippets and examples in the different [Wiki sections](https://github.com/marvin-we/steem-java-api-wrapper/wiki).  

## Contribute
The project became quite big and there is still a lot to do. If you want to support the project simply clone the git repository and submit a pull request. I would really appreciate it =).

> git clone https://github.com/marvin-we/steem-java-api-wrapper.git

## Get in touch!
Most of my projects are pretty time consuming and I always try to provide some useful stuff to the community. What keeps me going for that is your feedback and your support. For that reason I would love to get some Feedback from you <3. Just contact me here on [Steemit](https://steemit.com/@dez1337) or ping me on [GitHub](https://github.com/marvin-we/steem-java-api-wrapper).

<br /><hr/><em>Posted on <a href="https://utopian.io/utopian-io/@dez1337/steemj-dev-diary-2-02-01-2018-increased-code-quality">Utopian.io -  Rewarding Open Source Contributors</a></em><hr/>
👍 , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , ,