Steemnova - Fixed language issues on friend requests

View this thread on: d.buzz | hive.blog | peakd.com | ecency.com
·@mwfiae·
0.000 HBD
Steemnova - Fixed language issues on friend requests
## Bug Fix
### What was the issue?

There were issues in steemnova while sending/deleting/accepting friendrequests, if the language of the two users are different. 

![image.png](https://res.cloudinary.com/hpiynhbhq/image/upload/v1518569080/zpf5towrosw5wiwzuura.png)

For more details please see [my bugreport](https://steemit.com/utopian-io/@mwfiae/steemnova-error-message-on-friend-request) about this issue. 

[Related issue on Github](https://github.com/steemnova/steemnova/issues/29)
### What was the solution?
As seen in the screenshot the variable language was not defined.
This was the case everytime the language of the user and that of the "friend" were different.

So to fix the bug I searched the "ShowBuddyListPage" for all occurences of the language variable. I then replaced them with the correct language. 

![image.png](https://res.cloudinary.com/hpiynhbhq/image/upload/v1518905269/qs114ms5mhk6aaayhkrp.png)

![image.png](https://res.cloudinary.com/hpiynhbhq/image/upload/v1518905284/mdhmsaq3owdltqyuzxki.png)

![image.png](https://res.cloudinary.com/hpiynhbhq/image/upload/v1518905293/kzvnue7frf9bknmp6nfe.png)

As you can see the language of the current user is always in $USER['lang']. It is compared to the language of the other user, if they are different the language of the other user should be used. This is because it determines the language of the message that is send to the other user. 
As you can see the language of the other user is in the variables "$row['lang']", "$requestData['lang']" and "$sender['lang']" respectively.

[My PullRequest](https://github.com/steemnova/steemnova/pull/23)

<br /><hr/><em>Posted on <a href="https://utopian.io/utopian-io/@mwfiae/steemnova-fixed-language-issues-on-friend-requests">Utopian.io -  Rewarding Open Source Contributors</a></em><hr/>
👍 , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , ,